Change some d3d9 RACE( "stub ") into FIXME ("stub")

Mike Hearn mike at navi.cx
Tue Jan 4 11:21:41 CST 2005


On Tue, 04 Jan 2005 17:05:24 +0000, Oliver Stieber wrote:
> Hi, here's a little patch to write stubs in d3d9 out
> as fixme's instead of traces.

I'm afraid your patch is wrapped. It needs to be resubmitted.

One thing to be aware of when doing this is that some of these calls may
be used very frequently, and the cost of outputting a fixme for each one
is high. Because TRACEs are not output by default making a stub a TRACE is
often used in this situation.

Possibly a better way is to convert them to use a static variable so a
FIXME is output, but only once, like this:

HRESULT  WINAPI IDirect3DDevice9Impl_TestCooperativeLevel(LPDIRECT3DDEVICE9 iface) {
     IDirect3DDevice9Impl *This = (IDirect3DDevice9Impl *)iface;
     static LONG fixme = 1;
     
     if (InterlockedExchange(&fixme, 0)) FIXME("(%p) : stub\n", This);    /* No way of notifying yet! */

     return D3D_OK;
}

thanks -mike




More information about the wine-patches mailing list