[Patch 2/2] winmm: Improve initial MIDI player thread synchronisation.

Joerg-Cyril.Hoehle at t-systems.com Joerg-Cyril.Hoehle at t-systems.com
Thu Feb 11 02:54:29 CST 2010


Hi,
[oops, Patch 1 is the Valgrind one.  The Valgrind patch can be applied
 on its own, it's not "either both or none".  This one depends on it.]

I wrote this patch when I erroneously believed SuspendThread(myself)
does not work in Wine, because I confused thread handle and ID.
In fact, the previous patch is enough to make the test additions
pass, so I moved them from here to there.

This patch still cleans up a little bit and ought to prevent a
Valgrind error in my not yet submitted further MIDI tests, thanks to
the reordering of the initialisation of dwPulses.

Of course, getting rid of Suspend/ResumeThread is likely the way to
go.  Not top on my improvements list.

Regards,
 Jörg Höhle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 05-winmm-Fix-initial-MIDI-player-thread-synchronisatio.patch
Type: application/text
Size: 3817 bytes
Desc: 05-winmm-Fix-initial-MIDI-player-thread-synchronisatio.patch
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20100211/42693ef5/attachment.bin>


More information about the wine-patches mailing list