[PATCH] kernel32: avoid leaving com handle open (Coverity)

Marcus Meissner marcus at jet.franken.de
Sat Aug 31 03:11:09 CDT 2013


Hi,

1072970 Resource leak

(while resource leak ... not sure if leaking serial fds is good even in
 testcases, probably not.)

Ciao, Marcus
---
 dlls/kernel32/tests/comm.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/kernel32/tests/comm.c b/dlls/kernel32/tests/comm.c
index e5264c8..3e6b070 100644
--- a/dlls/kernel32/tests/comm.c
+++ b/dlls/kernel32/tests/comm.c
@@ -1180,6 +1180,7 @@ static void test_LoopbackDtrRing(void)
     if (dcb.fDtrControl == DTR_CONTROL_HANDSHAKE)
     {
 	trace("DTR_CONTROL_HANDSHAKE is set, so don't manipulate DTR\n");
+	CloseHandle(hcom);
 	return;
     }
     ok(GetCommModemStatus(hcom, &defaultStat), "GetCommModemStatus failed\n");
-- 
1.7.10.4




More information about the wine-patches mailing list