[PATCH] kernel32: avoid leaving com handle open (Coverity)

Marcus Meissner marcus at jet.franken.de
Sat Aug 31 03:16:48 CDT 2013


Hi,

1072970 Resource leak
1072971 Resource leak

(while resource leak ... not sure if leaking serial fds is good even in
 testcases, probably not.)

Also fixed tab vs space for the pattern.

Ciao, Marcus
---
 dlls/kernel32/tests/comm.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/dlls/kernel32/tests/comm.c b/dlls/kernel32/tests/comm.c
index e5264c8..923b367 100644
--- a/dlls/kernel32/tests/comm.c
+++ b/dlls/kernel32/tests/comm.c
@@ -1036,7 +1036,7 @@ static void test_LoopbackCtsRts(void)
     if (dcb.fRtsControl == RTS_CONTROL_HANDSHAKE)
     {
 	trace("RTS_CONTROL_HANDSHAKE is set, so don't manipulate RTS\n");
-        CloseHandle(hcom);
+	CloseHandle(hcom);
 	return;
     }
     ok(GetCommModemStatus(hcom, &defaultStat), "GetCommModemStatus failed\n");
@@ -1180,6 +1180,7 @@ static void test_LoopbackDtrRing(void)
     if (dcb.fDtrControl == DTR_CONTROL_HANDSHAKE)
     {
 	trace("DTR_CONTROL_HANDSHAKE is set, so don't manipulate DTR\n");
+	CloseHandle(hcom);
 	return;
     }
     ok(GetCommModemStatus(hcom, &defaultStat), "GetCommModemStatus failed\n");
@@ -1592,6 +1593,7 @@ static void test_WaitRing(void)
     ok((ret = GetCommModemStatus(hcom, &defaultStat)), "GetCommModemStatus failed\n");
     if (!ret) {
 	skip("modem status failed -> skip.\n");
+	CloseHandle(hcom);
 	return;
     }
     if(defaultStat & MS_RING_ON)
@@ -1668,7 +1670,7 @@ static void test_WaitDcd(void)
     if (dcb.fDtrControl == DTR_CONTROL_DISABLE)
     {
 	trace("DTR_CONTROL_HANDSHAKE is set, so don't manipulate DTR\n");
-        CloseHandle(hcom);
+	CloseHandle(hcom);
 	return;
     }
     args[0]= TIMEOUT >>1;
-- 
1.7.10.4




More information about the wine-patches mailing list