[PATCH] winemsibuilder: close handle in an exit path (Coverity)
Marcus Meissner
marcus at jet.franken.de
Sun Sep 29 12:24:45 CDT 2013
1099501 Resource leak
and also print a warning message
Ciao, Marcus
---
programs/winemsibuilder/main.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/programs/winemsibuilder/main.c b/programs/winemsibuilder/main.c
index ea4607e..9c0fe42 100644
--- a/programs/winemsibuilder/main.c
+++ b/programs/winemsibuilder/main.c
@@ -219,7 +219,11 @@ static int add_stream( const WCHAR *msifile, const WCHAR *stream, const WCHAR *f
}
size.QuadPart = low;
hr = IStream_SetSize( stm, size );
- if (hr != S_OK) goto done;
+ if (hr != S_OK) {
+ WINE_WARN( "failed to set stream size\n" );
+ CloseHandle( handle );
+ goto done;
+ }
while (ReadFile( handle, buffer, sizeof(buffer), &read, NULL ) && read)
{
--
1.7.10.4
More information about the wine-patches
mailing list