[PATCH] view: free the data on error exit (Coverity)

Marcus Meissner marcus at jet.franken.de
Sun Sep 29 12:33:57 CDT 2013


1099499 Resource leak
---
 programs/view/view.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/programs/view/view.c b/programs/view/view.c
index 9e60824..0adade7 100644
--- a/programs/view/view.c
+++ b/programs/view/view.c
@@ -166,8 +166,10 @@ static HMETAFILE GetPlaceableMetaFile( LPCWSTR szFileName )
   }
   CloseHandle( handle );
 
-  if (!(hmf = SetMetaFileBitsEx(mfHeader.mtSize*2, lpData)))
+  if (!(hmf = SetMetaFileBitsEx(mfHeader.mtSize*2, lpData))) {
+    GlobalFree(lpData);
     return 0;
+  }
 
 
   width = APMHeader.bbox.Right - APMHeader.bbox.Left;
@@ -181,6 +183,7 @@ static HMETAFILE GetPlaceableMetaFile( LPCWSTR szFileName )
 
   deltax = 0;
   deltay = 0 ;
+  GlobalFree(lpData);
   return hmf;
 }
 
-- 
1.7.10.4




More information about the wine-patches mailing list