Module: tools
Branch: master
Commit: 095ed074ceddecb57bf3293c5f85bfffc065b637
URL:
https://source.winehq.org/git/tools.git/?a=commit;h=095ed074ceddecb57bf3293…
Author: Francois Gouget <fgouget(a)codeweavers.com>
Date: Fri Aug 31 14:01:12 2018 +0200
testbot: Fail the task if the log contains perl errors or warnings.
They indicate the script needs fixing and they may mask other issues.
Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard(a)winehq.org>
---
testbot/lib/WineTestBot/LogUtils.pm | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/testbot/lib/WineTestBot/LogUtils.pm b/testbot/lib/WineTestBot/LogUtils.pm
index 5120217..b0b8040 100644
--- a/testbot/lib/WineTestBot/LogUtils.pm
+++ b/testbot/lib/WineTestBot/LogUtils.pm
@@ -71,7 +71,11 @@ sub ParseTaskLog($)
$Result = "badpatch";
last; # Should be the last and most specific message
}
- elsif ($Line =~ /^Task: /)
+ elsif ($Line =~ /^Task: / or
+ # Typical perl errors
+ $Line =~ /^Use of uninitialized value / or
+ $Line =~ /^Undefined subroutine / or
+ $Line =~ /^Global symbol /)
{
$Result = "failed";
}
@@ -111,7 +115,9 @@ sub GetLogLineCategory($)
$Line =~ /^Makefile:[0-9]+: recipe for target .* failed$/ or
$Line =~ /^(?:Build|Reconfig|Task): (?!ok)/ or
# Typical perl errors
- $Line =~ /^Use of uninitialized value/)
+ $Line =~ /^Use of uninitialized value / or
+ $Line =~ /^Undefined subroutine / or
+ $Line =~ /^Global symbol /)
{
return "error";
}