[Bug 31789] Fix handling of jscript/vbscript tests

wine-bugs at winehq.org wine-bugs at winehq.org
Mon Oct 26 14:57:50 CDT 2015


https://bugs.winehq.org/show_bug.cgi?id=31789

--- Comment #5 from François Gouget <fgouget at codeweavers.com> ---
Here's an impact analysis:
* bin/build/Reconfig.pl
  Produce a list of the C files in each directory.
* bin/WineRunReconfig.pl
  Retrieve and store the list of test C files somewhere.
* lib/WineTestBot/Patches.pm
  Detect patches that modify non-C files in a tests directory and then consult
the list of all Wine test C files we got from the Reconfig task to build a list
of tests we should probably run.

Drawbacks of this hacky approach:
* It's likely to cause mild test bombs: whenever this triggers the TestBot will
create one task per test per VM (with the current VM list for jscript that
would be 56 tasks for instance).
* Any failure in any of the tests being run will be reported, thus possibly
increasing the false positives rate (though obviously the fix is to make sure
the tests never fail).

So a better solution would instead do a global rebuild to figure out the exact
list of tests that need to be rebuilt and leverage the fix for bug 39512. But
that requires even more changes.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.


More information about the wine-bugs mailing list