[Bug 25857] Multiple games (Stronghold 2, Need for Speed: Carbon demo, Purge) fail to draw correctly because of ID3DXEffectImpl_*Pass calls

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=25857

--- Comment #67 from Paul Gofman <gofmanp at gmail.com> ---
(In reply to Wylda from comment #66)
> Paul this is awesome, Awesome and QUICK on top of that. I tested this new
> patch and problems in Fifa11, NFS MW, NFS Carbon are fixed. It's great to
> see, that these games are running with "winetricks alldlls=builtin".
> 
> We should try to keep 1 problem per bug, so i split the unrelated NFS to bug
> 40456. As on bug closure there is just one field for "Fixed by SHA1".
> 
I suppose there was no need for that as I was going to suggest a fix with a
unit test anyway and the bug record is not required for that. But since it is
already there I will reference it in the patch description.

> Some of your 3d patches already got in. Did it fixed at least one real
> application, so i can split this bug further. I don't understand the code,
> so it's not clear to me, patches vs. real application.
> 
Not yet, though most of the initial preshader implementation code is already
there :). Some games (possibly fifa11 for instance) will have good chances to
work after 4 patches currently left under review & my updates will get in (1st
4 ones from this test patch). So for now this bug is active and I suppose there
is no need to open separate bugs for specific effect states issues yet until it
is closed.

> Last point - yesterday i hit the problem from Comment 51, as i normally
> build with disabled optimizations, i.e. CFLAGS/CXXFLAGS "-g -O0"
> (significantly faster during regression hunting). And patch 08/10 brakes
> this build (it remind me unrelated bug 22717).

I will fix that in the next test patch update.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.