[Bug 45080] Null pointer dereference in member function of D3D11 device

[wine-bugs at winehq.org]

https://bugs.winehq.org/show_bug.cgi?id=45080

--- Comment #15 from Nikolay Sivov <bunglehead at gmail.com> ---
Created attachment 61239
  --> https://bugs.winehq.org/attachment.cgi?id=61239
patch

(In reply to Toni from comment #14)
> (In reply to Nikolay Sivov from comment #13)
> > 
> > I don't think it's useful. If you're going to edit it, you should be adding
> > new methods too so you don't have to guess later why it failed.
> 
> 
> Well, it's the easiest thing to try first, then of course the new methods
> need to be added but that will require more work, and my suggestion is to
> just try and add -that one line- and see what happens. Also, looking at the
> new methods in IDXGIDevice2 they don't even look that useful for a game, so
> who knows. If the app fails afterwards in an undeclared IDXGIDevice2 method
> it will be really obvious in apitrace since it will be the last line, akin
> to what happened in bug 41063.
> 

Thing is we have custom methods right after IDXGIDevice1 ones. I don't know
much about apitrace, but I'm assuming it hooks vtables somehow. Advertising
IDXGIDevice2 will let it hook custom methods using wrong prototypes.

Completion event method looks like something application could be using.
Anyway, attaching a patch.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.