[Bug 35533] Make it possible to see the sent patch files inline without extra download step

wine-bugs at winehq.org wine-bugs at winehq.org
Tue Jun 26 17:41:51 CDT 2018


https://bugs.winehq.org/show_bug.cgi?id=35533

--- Comment #5 from François Gouget <fgouget at codeweavers.com> ---
On the JobDetails page one can download two types of files:
* Patches
* The resulting Windows executables (or those uploaded by the developer).

GetFile.pl used to indiscriminately return application/octet-stream. Now it
sets the MIME type to test/plain for patches so the browser typically offers
opening them in a text editor (at least that's what happens in Firefox).

It's maybe not quite as nice as viewing the patch inline but it's still better
than the previous situation.

commit 6dde8de8257a1333a8951a0e6cd11f5f41e01d80
Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Tue Jun 26 13:40:47 2018 +0200

    testbot/web: Adjust the GetFile MIME type based on Step->FileType.

    This lets the browser offer to open the patches in a text editor instead
    of systematically suggesting to save them to disk.

    Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
    Signed-off-by: Alexandre Julliard <julliard at winehq.org>

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.


More information about the wine-bugs mailing list