[Bug 35533] Make it possible to see the sent patch files inline without extra download step

wine-bugs at winehq.org wine-bugs at winehq.org
Fri Jun 29 03:45:58 CDT 2018


https://bugs.winehq.org/show_bug.cgi?id=35533

--- Comment #6 from Dmitry Timoshkov <dmitry at baikal.ru> ---
(In reply to François Gouget from comment #5)
> On the JobDetails page one can download two types of files:
> * Patches
> * The resulting Windows executables (or those uploaded by the developer).
> 
> GetFile.pl used to indiscriminately return application/octet-stream. Now it
> sets the MIME type to test/plain for patches so the browser typically offers
> opening them in a text editor (at least that's what happens in Firefox).

I have two browsers in my Linux system: Firefox 52.8.0 (64-bit) and Chromium
version 61.0.3163.100 (64-bit). After going for instance to the following
URL https://testbot.winehq.org/JobDetails.pl?Key=39460 in both browsers and
clicking patch.diff Firefox does show an "Open file with..." dialog and
after choosing the text editor the file gets opened in the editor. However
Chromium still suggests only to save the file to disk.

> It's maybe not quite as nice as viewing the patch inline but it's still
> better than the previous situation.

I'm sorry, but no, it's not better in any way. It's ugly and unusable.
For a comparison just see how Wine bugzilla manages the text attachments.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.


More information about the wine-bugs mailing list