[Bug 48291] Detroit: Become Human crashes on launch

WineHQ Bugzilla wine-bugs at winehq.org
Thu Dec 26 09:37:03 CST 2019


https://bugs.winehq.org/show_bug.cgi?id=48291

Zebediah Figura <z.figura12 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.figura12 at gmail.com

--- Comment #27 from Zebediah Figura <z.figura12 at gmail.com> ---
(In reply to Paul Gofman from comment #26)
> Created attachment 66102 [details]
> Don't use futexes for unaligned addresses
> 
> Regarding p. 4., the reason is the game is passing unaligned addresses for
> condition variables. That works somehow on Windows and in Wine fallback
> path, but not with futexes. I am attaching a bit better patch which fixes
> the issue.

Nice find!

On 64-bit machines, we actually have 8 bits to work with, which means we could
manually align the address upward, at least for condition variables and SRW
locks.

Note also that address waits are hashed, so we don't need to use the server
path for those even if they're unaligned.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.



More information about the wine-bugs mailing list