[Bug 51049] Sea of Thieves crash when entering a lobby

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51049

--- Comment #1 from Hans Leidekker <hans at meelstraat.net> ---
(In reply to Alistair Leslie-Hughes from comment #0)
> After you set Sail in "Sea of Thieves", it crash due to a secur32 error.
> 
> Prior to to commit f93284dfa44b060436c6a0617b51280abb3f24fc, it worked as
> expected.  

Before DTLS support it may have used a fallback path, presumably regular TLS.

> The crash occurs in function schan_InitializeSecurityContextW.  The scenario
> is that it create a SCHAN_HANDLE_CTX handle, then later frees it.  Then
> attempts to  create another SCHAN_HANDLE_CTX, however passes the same
> parameters through except pInput (which is NULL).
> 
> Previous, this would return SEC_E_INCOMPLETE_MESSAGE, since the pInput was
> NULL, however however now, it jumps through to 
> else if (!is_dtls_context(ctx)) return SEC_E_INCOMPLETE_MESSAGE;
> 
> However the ctx has already been freed in this case and then crashes.

We should probably reject invalid handles to avoid a crash, but it seems to me
the real problem might be in a previous call.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.