Rob Shearman : winedos: Compare HRESULT value explicitly against S_OK instead of using an implicit ! = 0 comparison.

Alexandre Julliard julliard at winehq.org
Wed Oct 1 14:09:41 CDT 2008


Module: wine
Branch: master
Commit: 2c37baba0a4c692a93beef69e7456570a64923b2
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=2c37baba0a4c692a93beef69e7456570a64923b2

Author: Rob Shearman <robertshearman at gmail.com>
Date:   Wed Oct  1 11:20:53 2008 +0100

winedos: Compare HRESULT value explicitly against S_OK instead of using an implicit != 0 comparison.

---

 dlls/winedos/vga.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/dlls/winedos/vga.c b/dlls/winedos/vga.c
index 288f867..96cadb9 100644
--- a/dlls/winedos/vga.c
+++ b/dlls/winedos/vga.c
@@ -459,7 +459,8 @@ static void WINAPI VGA_DoSetMode(ULONG_PTR arg)
             lpddraw=NULL;
             return;
         }
-        if ((res=IDirectDrawPalette_SetEntries(lpddpal,0,0,256,vga_def_palette))) {
+        res=IDirectDrawPalette_SetEntries(lpddpal,0,0,256,vga_def_palette);
+        if (res != S_OK) {
             ERR("Could not set default palette entries (res = 0x%x)\n", res);
         }
 




More information about the wine-cvs mailing list