Marcus Meissner : kernel32: Handle username conversion failure (Coverity).

Alexandre Julliard julliard at winehq.org
Mon Feb 2 09:01:18 CST 2009


Module: wine
Branch: master
Commit: 5493b77290a91045d9cd0154248da1ab0a67ad90
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=5493b77290a91045d9cd0154248da1ab0a67ad90

Author: Marcus Meissner <marcus at jet.franken.de>
Date:   Sat Jan 31 11:50:21 2009 +0100

kernel32: Handle username conversion failure (Coverity).

---

 dlls/kernel32/process.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c
index 942b97a..56e23b8 100644
--- a/dlls/kernel32/process.c
+++ b/dlls/kernel32/process.c
@@ -495,6 +495,7 @@ static void set_additional_environment(void)
         MultiByteToWideChar( CP_UNIXCP, 0, name, -1, user_name, len );
         SetEnvironmentVariableW( usernameW, user_name );
     }
+    else WARN( "user name %s not convertible.\n", debugstr_a(name) );
 
     /* set the USERPROFILE and ALLUSERSPROFILE variables */
 
@@ -522,8 +523,10 @@ static void set_additional_environment(void)
         strcpyW( value, profile_dir );
         p = value + strlenW(value);
         if (p > value && p[-1] != '\\') *p++ = '\\';
-        strcpyW( p, user_name );
-        SetEnvironmentVariableW( userprofileW, value );
+        if (user_name) {
+            strcpyW( p, user_name );
+            SetEnvironmentVariableW( userprofileW, value );
+        }
         if (all_users_dir)
         {
             strcpyW( p, all_users_dir );




More information about the wine-cvs mailing list