Michael Stefaniuc : cabinet: Avoid TRUE-FALSE conditional expressions.

Alexandre Julliard julliard at winehq.org
Thu Jul 26 15:34:58 CDT 2012


Module: wine
Branch: master
Commit: f631780da4356943e91477fb7a393c10024b528a
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=f631780da4356943e91477fb7a393c10024b528a

Author: Michael Stefaniuc <mstefani at redhat.de>
Date:   Thu Jul 26 11:26:28 2012 +0200

cabinet: Avoid TRUE-FALSE conditional expressions.

---

 dlls/cabinet/fdi.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/dlls/cabinet/fdi.c b/dlls/cabinet/fdi.c
index 7fcf4cb..3d1aec9 100644
--- a/dlls/cabinet/fdi.c
+++ b/dlls/cabinet/fdi.c
@@ -703,9 +703,9 @@ static BOOL FDI_read_entries(
   pfdici->cFiles    = num_files;
   pfdici->setID     = setid;
   pfdici->iCabinet  = cabidx;
-  pfdici->fReserve  = (flags & cfheadRESERVE_PRESENT) ? TRUE : FALSE;
-  pfdici->hasprev   = (flags & cfheadPREV_CABINET) ? TRUE : FALSE;
-  pfdici->hasnext   = (flags & cfheadNEXT_CABINET) ? TRUE : FALSE;
+  pfdici->fReserve  = (flags & cfheadRESERVE_PRESENT) != 0;
+  pfdici->hasprev   = (flags & cfheadPREV_CABINET) != 0;
+  pfdici->hasnext   = (flags & cfheadNEXT_CABINET) != 0;
   return TRUE;
 }
 
@@ -2815,7 +2815,7 @@ BOOL __cdecl FDICopy(
       fdin.pv = pvUser;
       fdin.psz1 = (char *)file->filename;
       fdin.hf = filehf;
-      fdin.cb = (file->attribs & cffile_A_EXEC) ? TRUE : FALSE; /* FIXME: is that right? */
+      fdin.cb = (file->attribs & cffile_A_EXEC) != 0; /* FIXME: is that right? */
       fdin.date = file->date;
       fdin.time = file->time;
       fdin.attribs = file->attribs; /* FIXME: filter _A_EXEC? */




More information about the wine-cvs mailing list