Michael Stefaniuc : shell32/tests: Remove redundant NULL checks before CoTaskMemFree().

Alexandre Julliard julliard at winehq.org
Fri Jul 8 10:02:04 CDT 2016


Module: wine
Branch: master
Commit: afe0ba175cc0507290a82cd97da5e0a141932533
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=afe0ba175cc0507290a82cd97da5e0a141932533

Author: Michael Stefaniuc <mstefani at redhat.de>
Date:   Fri Jul  8 10:10:33 2016 +0200

shell32/tests: Remove redundant NULL checks before CoTaskMemFree().

Signed-off-by: Michael Stefaniuc <mstefani at redhat.de>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/shell32/tests/brsfolder.c | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/dlls/shell32/tests/brsfolder.c b/dlls/shell32/tests/brsfolder.c
index 0ef5bb1..bf29d11 100644
--- a/dlls/shell32/tests/brsfolder.c
+++ b/dlls/shell32/tests/brsfolder.c
@@ -248,10 +248,8 @@ static void test_click_make_new_folder_button(void)
     shfileop.fFlags = FOF_NOCONFIRMATION|FOF_NOERRORUI|FOF_SILENT;
     SHFileOperationA(&shfileop);
 
-    if (pidl)
-        CoTaskMemFree(pidl);
-    if (test_folder_pidl)
-        CoTaskMemFree(test_folder_pidl);
+    CoTaskMemFree(pidl);
+    CoTaskMemFree(test_folder_pidl);
     test_folder_object->lpVtbl->Release(test_folder_object);
 
     CoUninitialize();
@@ -346,16 +344,12 @@ static void test_selection(void)
     /* test without flags */
     bi.ulFlags = 0;
     pidl = SHBrowseForFolderA(&bi);
-
-    if (pidl)
-        CoTaskMemFree(pidl);
+    CoTaskMemFree(pidl);
 
     /* test with flag */
     bi.ulFlags = BIF_NEWDIALOGSTYLE;
     pidl = SHBrowseForFolderA(&bi);
-
-    if (pidl)
-        CoTaskMemFree(pidl);
+    CoTaskMemFree(pidl);
 
     IShellFolder_Release(desktop_object);
 




More information about the wine-cvs mailing list