=?UTF-8?Q?J=C3=B3zef=20Kucia=20?=: wined3d: Use snprintf() in init_debug_buffer() (Coverity).

Alexandre Julliard julliard at winehq.org
Thu Aug 16 13:42:48 CDT 2018


Module: wine
Branch: master
Commit: f51f911ae5503975c43e1ec80667942c37c60395
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=f51f911ae5503975c43e1ec80667942c37c60395

Author: Józef Kucia <jkucia at codeweavers.com>
Date:   Wed Aug 15 11:09:48 2018 +0200

wined3d: Use snprintf() in init_debug_buffer() (Coverity).

Signed-off-by: Józef Kucia <jkucia at codeweavers.com>
Signed-off-by: Henri Verbeet <hverbeet at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/wined3d/utils.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c
index 800cdc4..861f169 100644
--- a/dlls/wined3d/utils.c
+++ b/dlls/wined3d/utils.c
@@ -4340,9 +4340,9 @@ struct debug_buffer
 
 static void init_debug_buffer(struct debug_buffer *buffer, const char *default_string)
 {
-    strcpy(buffer->str, default_string);
+    snprintf(buffer->str, sizeof(buffer->str), "%s", default_string);
     buffer->ptr = buffer->str;
-    buffer->size = ARRAY_SIZE(buffer->str);
+    buffer->size = sizeof(buffer->str);
 }
 
 static void debug_append(struct debug_buffer *buffer, const char *str, const char *separator)
@@ -4355,7 +4355,7 @@ static void debug_append(struct debug_buffer *buffer, const char *str, const cha
     if (size == -1 || size >= buffer->size)
     {
         buffer->size = 0;
-        strcpy(&buffer->str[ARRAY_SIZE(buffer->str) - 4], "...");
+        strcpy(&buffer->str[sizeof(buffer->str) - 4], "...");
         return;
     }
 




More information about the wine-cvs mailing list