=?UTF-8?Q?J=C3=B3zef=20Kucia=20?=: wined3d: Use snprintf() in shader_arb_request_a0() (Coverity).

Alexandre Julliard julliard at winehq.org
Thu Aug 16 13:42:48 CDT 2018


Module: wine
Branch: master
Commit: becec522c4a37e71dbe08b1395ef77de2fb77949
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=becec522c4a37e71dbe08b1395ef77de2fb77949

Author: Józef Kucia <jkucia at codeweavers.com>
Date:   Wed Aug 15 11:09:49 2018 +0200

wined3d: Use snprintf() in shader_arb_request_a0() (Coverity).

Signed-off-by: Józef Kucia <jkucia at codeweavers.com>
Signed-off-by: Henri Verbeet <hverbeet at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/wined3d/arb_program_shader.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/dlls/wined3d/arb_program_shader.c b/dlls/wined3d/arb_program_shader.c
index c05dca0..00b326f 100644
--- a/dlls/wined3d/arb_program_shader.c
+++ b/dlls/wined3d/arb_program_shader.c
@@ -987,9 +987,10 @@ static void shader_arb_request_a0(const struct wined3d_shader_instruction *ins,
     struct shader_arb_ctx_priv *priv = ins->ctx->backend_data;
     struct wined3d_string_buffer *buffer = ins->ctx->buffer;
 
-    if (!strcmp(priv->addr_reg, src)) return;
+    if (!strcmp(priv->addr_reg, src))
+        return;
 
-    strcpy(priv->addr_reg, src);
+    snprintf(priv->addr_reg, sizeof(priv->addr_reg), "%s", src);
     shader_addline(buffer, "ARL A0.x, %s;\n", src);
 }
 




More information about the wine-cvs mailing list