Visual-MinGW: Winelib patch

Dimitrie O. Paun dpaun at rogers.com
Tue Dec 31 11:59:23 CST 2002


On December 31, 2002 01:52 pm, Manu wrote:
> -mno-cygwin don't have much sense, since Visual-MinGW is built with
> MinGW, under Windows, not Cygwin.

Yes, I know, but -mno-cygwin should be a noop in that case. And if
someone has cygwin installed, it will ensure that Visual-MinGW is
not linked against the cygwin libs. I think we are in agreement here
that Visual-MinGW should not depend on cygwin, no? If so, it makes
sense to make this explicit with -mno-cygwin.

> >   -- Do not use -pedantic, the code does not compile with gcc 3.2
> >      on Linux with that flag.
> >   -- Do not use -fvtable-thunks, it is deprecated in gcc 3.2
> >
> > Please apply this patch with 'patch -p1 < winelib.diff'.
>
> Apparently, the patch refuses to be applied, probably due to
> the fact that I changed a few things in makefiles formating.

OK, I can create a new patch for you.

> BTW, makefiles are generated by Visual-MinGW, so I
> suggest to add dedicated makefiles for Winelib.
> eg: "makefile.wine".

I can certainly do that, but then they will drift appart.
The ideal situation is to support both mingw and wine out
of the same makefile, so that everything "just works".
If makefile is generated by Visual-MinGW, I think it's worth
modifying Visual-MinGW so that it generates the right makefile
for both mingw and wine, don't you think so? This way, all
programs that use Visual-MinGW can benefit from this support.

-- 
Dimi.




More information about the wine-devel mailing list