PATCH: ppc fix 2
meissner at suse.de
Mon Nov 4 08:38:29 CST 2002
On Wed, Oct 30, 2002 at 10:13:36AM -0600, Greg Turner wrote:
> On Wednesday 30 October 2002 07:22 am, Marcus Meissner wrote:
> > Fixed LITTLE_ENDIAN_32_READ macro to at least compile.
> btw, this seems to imply that even with the parentheses fix, it's still
> not right... is that the case? You seem like somebody who's up on PPC
> issues. Note that this is only intended to support UINT32's (I'll make
> that clearer by changing the macro names in an upcoming patch).
The macro appears ok:
(*(pchar) = LOBYTE(LOWORD(uint32)), \
*((pchar)+1) = HIBYTE(LOWORD(uint32)), \
*((pchar)+2) = LOBYTE(HIWORD(uint32)), \
*((pchar)+3) = HIBYTE(HIWORD(uint32)), \
It is not byteorder dependend.
> Anyhow, just thinking aloud there, and, I guess, hoping that if I'm
> getting this all wrong, someone will correct me. My original question
> is the main one: are the semantics of my macro's wrong, or just the
> parentheses thing?
Huh? Just the parentheses thing was wrong I think.
More information about the wine-devel