[PATCH] Re: [PATCH] some dc:LockWindowUpdate work

[Christian Neumair]

Am Fre, 2002-10-18 um 17.34 schrieb Alexandre Julliard:
> Christian Neumair <chris at gnome-de.org> writes:
> 
> > The version in HEAD actually doesn't unlock the window inside the
> > function but just exits the if loop. The patch adds an unlock function
> > (see msdn, when not passing hwnd, the active window should be unlocked)
> > and moves the stub to the place where it belongs. Basically this makes
> > the code easier to read. If you want we can remove the whole if (!hwnd)
> > code because if hwnd is 0, lockedWnd = hwnd does the right thing, too.
> 
> Well, it already does the right thing today, so I don't see why you
> need to change it. If it's just to make it more readable OK, but I
> don't see much point given that this function is completely wrong
> anyway. And I definitely don't see a reason for removing the fixme
> message.
I see a reason: FIXME denotes that something should be fixed, but in
this place we don't need to fix anything. I prepared a really small
patch, have a look at it and tell me if you still find the cleanup
obsolete. And I think it's not a good idea to tell the users that
something has gone wrong (stub) while the desired action was taken
without any problems.

regs,
 Chris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dce.c
Type: text/x-c
Size: 18655 bytes
Desc: 
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20021018/be8838c0/dce.bin