SystemParametersInfo patch

Duane Clark dclark at
Wed Mar 5 10:45:58 CST 2003

Jon Bright wrote:
> ...
> (as an aside are patches preferred as MIME attachments or straight in
> the mail here?)

I will just throw in a couple more comments to add to those already 
made. The main problem with the way you attached this is that it has 
modified a lot of the "special" characters, which you normally don't see 
because your mail reader has displays them ok. So you should do a "view 
source" of what you have attached. For example, it starts out:

diff -u -r1.49 sysparams.c
--- windows/sysparams.c	19 Feb 2003 22:04:46 -0000	1.49
+++ windows/sysparams.c	5 Mar 2003 10:39:39 -0000
@@ -1662,17 +1662,26 @@
      case SPI_GETMOUSEHOVERWIDTH:		/*     98  _WIN32_WINNT >=3D 0x400 
|| _W=
IN32_WINDOW > 0x400 */

Notice the "=20", "=3D", and "=<cr>". Not only has the mailer changed 
some of the characters, but it has inserted line feeds. For many of us, 
all this is invisible. I use Mozilla, and it recreates the file 
correctly as long as I Save As... text. But I don't think we should 
assume that everyone can do that.

More information about the wine-devel mailing list