gethostbyname patch

Dimitrie O. Paun dimi at intelliware.ca
Tue May 6 09:07:34 CDT 2003


On Tue, 6 May 2003, Andreas Mohr wrote:

> +    if (name == NULL)
> +    {
> +	if (WS_gethostname(local_name, sizeof(local_name)) != 0)
> +		FIXME("failed to get local host name, please report!\n");

There is nothing to fix here. This is at most a WARN, but if
WS_gethostname() is documented as possibly failing, that's
just fine, no need for any message, just return failure:

+     if (WS_gethostname(local_name, sizeof(local_name))) return NULL;

-- 
Dimi.






More information about the wine-devel mailing list