icmp - allow building on MS_VC and Mingw

Hans Leidekker hans at it.vu.nl
Thu Sep 23 04:55:22 CDT 2004


On Thursday 23 September 2004 06:02, Steven Edwards wrote:

> Feel free to drop the gettimeofday part from this patch. There are 16
> other source files where we call gettimeofday in Wine and I am sure if
> you dont accept it I can come up a good implementation in libwine. 

Why not use Windows time functions directly in ICMP? Reimplementing
gettimeofday on top of Windows time fuctions doesn't seem like an
ideal solution for ReactOS nor Wine.

In Reactos you'd already have unnecessary loss of precision but even
more so in Wine since we'd be doing:

 gettimeofday() -> GetSysTemTimeAsFileTime() -> gettimeofday().

Not to mention the maintenance burden of a Unix api in Reactos and Wine.

 -Hans



More information about the wine-devel mailing list