x11drv: use of uninitialized rect

James Hawkins truiken at gmail.com
Tue Aug 23 20:18:09 CDT 2005


Hey,

While compiling x11drv, gcc gives the following error:

gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include
-D__WINESRC__   -D_REENTRANT -fPIC -Wall -pipe
-mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+
-Wpointer-arith  -g -O2  -o text.o text.c
text.c: In function 'X11DRV_ExtTextOut':
text.c:85: warning: 'rect.bottom' is used uninitialized in this function
text.c:85: warning: 'rect.top' is used uninitialized in this function
text.c:85: warning: 'rect.right' is used uninitialized in this function
text.c:85: warning: 'rect.left' is used uninitialized in this function

Looking through the CVS log for text.c, I saw that before the latest
patch, rect would be initialized if lprect == NULL; otherwise, rect =
*lprect.  My guess is that we want to use lprect instead of rect, but
I'm not familiar enough with that code to make the change.  Can you
take a look at this Huw?

Thanks,
James Hawkins




More information about the wine-devel mailing list