Warnings left when compiling on GNU/Linux
vberon at mecano.gme.usherb.ca
Wed Jan 5 19:31:58 CST 2005
Le mer 05/01/2005 à 15:12, Walt Ogburn a écrit :
> Hi Gerald,
> The metafile.c warning is because of a test that is commented out in
> dlls/gdi/test/metafile.c. It's commented out instead of protected with
> todo because it doesn't just fail, it crashes. Perhaps the rtlstr test
> warnings are there for similar reasons.
The rtlstr tests are commented out because they use a loop (to iterate
through chars), and some of them are ok and some others are not.
So if we put them in a simple ok test, we'll get failures for some
chars, and if we put them in a todo block, then we'll get failures for
all the other cases which work fine.
We could get on with a todo_table listing for which chars we fail, but I
think (Dmitry can correct me as I'm likely wrong here) these tests are
locale-dependant, so we're in for more problems using that method.
IOW, don't count those tests to be uncommented tomorrow morning.
> There's a patch to make the metafile test pass, which also un-comments the
> test, at
> The patch hasn't been committed, but if anybody wants to make it nicer and
> try again, feel free to do so.
> - Walter
> On Wed, 5 Jan 2005, Gerald Pfeifer wrote:
> > When compiling on SUSE LINUX 9.2 using GCC 3.3.5 the following are the
> > only warnings I'm getting for current Wine CVS:
> > metafile.c:395: warning: `test_mf_PatternBrush' defined but not used
> > rtlstr.c:552: warning: `test_RtlUpcaseUnicodeChar' defined but not used
> > rtlstr.c:578: warning: `test_RtlUpcaseUnicodeString' defined but not used
> > rtlstr.c:629: warning: `test_RtlDowncaseUnicodeString' defined but not used
> > hlp2sgml.c:219: warning: `%x' yields only last 2 digits of year in some locales
> > On FreeBSD 4.10 using GCC 3.3.4 I am also seeing the following one:
> > fd.c:572: warning: right shift count >= width of type
> > fd.c:574: warning: right shift count >= width of type
> > Any chance we could get rid of these? :-)
> > Gerald
More information about the wine-devel