[QCAP] Final patch
Andreas Mohr
andi at rhlx01.fht-esslingen.de
Fri May 20 03:37:40 CDT 2005
Hi,
On Thu, May 19, 2005 at 09:20:25PM -0400, Dimi Paun wrote:
> On Fri, 2005-05-20 at 00:42 +0200, Maarten Lankhorst wrote:
> > +
> > + capBox->fd = open(device, O_RDWR | O_NONBLOCK);
> > + if (capBox->fd == -1) {
> > + ERR("%s: Failed to open: %s\n", device, strerror(errno));
> > + CoTaskMemFree(capBox);
> > + return E_FAIL;
> > + }
>
> This is a TRACE or WARN at most.
This should not be a TRACE, since it is an anomaly.
It should perhaps even be a MESSAGE (since the user might want to
know about broken permissions). Or just WARN instead.
> > + ERR("Tinkerer detected? Thou shalt not define HAVE_V4L2\n");
> > + CoTaskMemFree(capBox);
> > + close(capBox->fd);
> > + return E_FAIL;
>
> This is a FIXME.
It's not. His comments indicate that he has no plans whatsoever
to add V4L2 support since it's entirely unneeded, thus there's nothing
to be "fixed".
Andreas
More information about the wine-devel
mailing list