http://cvs.winehq.org/patch.py?id=19897 (shlfolder.c test)
Paul Vriens
Paul.Vriens at xs4all.nl
Sun Sep 4 08:26:52 CDT 2005
On Sun, 2005-09-04 at 16:17 +0300, Saulius Krasuckas wrote:
> * On Sat, 3 Sep 2005, Saulius Krasuckas wrote:
> > * On Sat, 3 Sep 2005, Paul Vriens wrote:
> > >
> > > this change to shell32/tests/shlfolder.c fails on Win98/WinNT and
> > > W2KProf because ILFindLastID is not exported on those platforms.
> > >
> > > I tried to change shlfolder.c to test for the export, but that shows
> > > that it's not exported on Wine either ? The .spec file says different.
> >
> > I have made pretty trivial change and it worksforme. See below.
>
> I believe the test works a lot better now. Still I tried upgrading my RH8
> glibc to one of FC4 and now I sit even w/o XF. :-/
>
>
> Log message:
> Saulius Krasuckas <saulius.krasuckas at ieee.org>
> SHELL32.dll.ILFindLastID is exported by an ordinal on an older platforms.
...
> /* This test shows that Windows doesn't allocate a new pidlLast, but returns a pointer into
> * pidlTestFile (In accordance with MSDN). */
> - todo_wine{ok (ILFindLastID(pidlTestFile) == pidlLast,
> + todo_wine{ok (pILFindLastID(pidlTestFile) == pidlLast,
> "SHBindToParent doesn't return the last id of the pidl param!\n");}
Shouldn't we (for consistency sake) surround the call to pILFindLastID
with a:
if (pILFindLastID)
Cheers,
Paul.
More information about the wine-devel
mailing list