[Setuapi] implement SetupDiCreateDeviceInfoListExW
Huw Davies
huw at codeweavers.com
Tue Jun 13 09:00:37 CDT 2006
On Tue, Jun 13, 2006 at 03:42:22PM +0200, Christian Gmeiner wrote:
> diff --git a/dlls/setupapi/devinst.c b/dlls/setupapi/devinst.c
> index f402f00..c24ae1e 100644
> --- a/dlls/setupapi/devinst.c
> +++ b/dlls/setupapi/devinst.c
> HDEVINFO WINAPI
> -SetupDiCreateDeviceInfoListExW(const GUID *ClassGuid,
> - HWND hwndParent,
> - PCWSTR MachineName,
> - PVOID Reserved)
> +SetupDiCreateDeviceInfoListExW(
> + const GUID *ClassGuid,
> + HWND hwndParent,
> + PCWSTR MachineName,
> + PVOID Reserved)
Please avoid these unnecessary whitespace changes, they just make the
patch bigger.
> diff --git a/dlls/setupapi/setupapi_private.h b/dlls/setupapi/setupapi_private.h
> index bce05cb..77e4fb0 100644
> --- a/dlls/setupapi/setupapi_private.h
> +++ b/dlls/setupapi/setupapi_private.h
> +struct DeviceInfoSet
> +{
> + DWORD magic; /* if is equal to SETUP_DEVICE_INFO_SET_MAGIC struct is okay */
> + GUID ClassGuid;
> + PWSTR MachineName;
> + HWND hwndParent;
> +};
> +
Is this struct going to be used by functions outside devinst.c? If
not then this should be moved into that file.
Also please include a test with your patch and, in this case, I think
it makes sense to include the appropiate Destroy function too, that
way it's easy to check that you haven't introduced a memory leak.
Thanks,
Huw.
--
Huw Davies
huw at codeweavers.com
More information about the wine-devel
mailing list