[PATCH 1/5] lz32/tests: Test more last errors set by LZOpenFile[AW].

Saulius Krasuckas saulius2 at ar.fi.lt
Mon Oct 9 10:29:42 CDT 2006

* On Fri, 6 Oct 2006, Alexandre Julliard wrote:
> * Saulius Krasuckas <saulius2 at ar.fi.lt> writes:
> > That was the reason I kept the check in.  It doesn't enforce 
> > unnecessary complexity in the function, so I doubt the check is wrong.  
> > Especially given that this fn on both platforms behaves *quite* 
> > differently while operating on compressed file(name)s.
> Testing last error on success is not useful. It will only cause spurious 
> test failures, so it should be done only if the API specifies a certain 
> behavior, or if you have a real app that depends on it.

Well, seems I had already forgotten whether the essential behaviour is a 
success here or not.  The fn acts quite weird on WinME, so I've been 
treating almost any its behaviour as a failure.  Thanks goes to both of 
you for opening my eyes, Vitaliy and Alexandre.

More information about the wine-devel mailing list