[PATCH 1/1] wined3d: Make 8bpp a valid depth in EnumAdapterModes

Chris Robinson chris.kcat at gmail.com
Mon Apr 2 00:52:23 CDT 2007

On Saturday 31 March 2007 02:25:52 am you wrote:
> You can change WineD3D to allow WINED3DFMT_P8, but you have to modify d3d8
> and d3d9 to filter it out. This is the correct approach then. Injecting P8
> in ddraw will work too, but it is not correct from the design point of
> view(since then wined3d says "I can't do that", and ddraw says "But I
> insist you can do it"

How about the attached patch? If not given an explicit mode, DDraw will loop 
over known good formats and not pass WINED3DFMT_UNKNOWN to WineD3D at all. 
Someone can then fix D3D8 to not pass it either, then fix WineD3D to not have 
special handling for enumerating WINED3DFMT_UNKNOWN. That should fix the 
current DDraw problem fine, and not immediately risk breaking D3D8 in the 

Vitaly Budovski, does this fix the problem as well?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ddraw.diff
Type: text/x-diff
Size: 4727 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20070401/de8f6f05/ddraw-0001.bin

More information about the wine-devel mailing list