[GDI+: 2/10] first pen test

Detlef Riekenberg wine.dev at web.de
Tue Jun 12 12:45:23 CDT 2007


On Mo, 2007-06-11 at 11:52 -0700, Evan Stade wrote:
> +
> +    status = GdipCreatePen1((ARGB)0xffff00ff, 10.0f, UnitPixel,
> &pen);
> +
> +    todo_wine
> +        expect(GdiplusNotInitialized, status);
> +
> +    GdipDeletePen(pen);
> +} 

Is pen set to NULL, when GdipCreatePen1 failed?
This ist not checked in your test and not done in your implementation,
but you pass uninitialized garbage (pen) to GdipDeletePen.

You might want to use:
-    GpPen *pen;
+    GpPen *pen = NULL;
and 
-    GdipDeletePen(pen);
+    if (status == Ok) then GdipDeletePen(pen);



Thanks

-- 
 
By by ... Detlef





More information about the wine-devel mailing list