[GDI+: 2/10] first pen test

Evan Stade estade at gmail.com
Tue Jun 12 12:50:48 CDT 2007


On 6/12/07, Detlef Riekenberg <wine.dev at web.de> wrote:
> On Mo, 2007-06-11 at 11:52 -0700, Evan Stade wrote:
> > +
> > +    status = GdipCreatePen1((ARGB)0xffff00ff, 10.0f, UnitPixel,
> > &pen);
> > +
> > +    todo_wine
> > +        expect(GdiplusNotInitialized, status);
> > +
> > +    GdipDeletePen(pen);
> > +}
>
> Is pen set to NULL, when GdipCreatePen1 failed?
> This ist not checked in your test and not done in your implementation,
> but you pass uninitialized garbage (pen) to GdipDeletePen.
>
> You might want to use:
> -    GpPen *pen;
> +    GpPen *pen = NULL;
> and
> -    GdipDeletePen(pen);
> +    if (status == Ok) then GdipDeletePen(pen);
>
>
>
> Thanks
>
> --
>
> By by ... Detlef

In the native GDI+ passing uninitialized garbage to GdipDeletePen is
not harmful.



More information about the wine-devel mailing list