[2/3] comctl32: Never draw item text with OPAQUE.

Dimi Paun dimi at lattica.com
Fri Mar 16 14:51:33 CDT 2007

On Fri, March 16, 2007 16:37, Felix Nawothnig wrote:
>> It seems to me that this is a bit of a problem:
>> 3783     if (nSubItem == 0 || (cdmode & CDRF_NOTIFYITEMDRAW))
>> 3784         prepaint_setup(infoPtr, hdc, &nmlvcd);
>> 3785
>> 3786     /* in full row select, subitems, will just use main item's colors */
>> 3787     if (nSubItem && uView == LVS_REPORT && (infoPtr->dwLvExStyle & LVS_EX_FULLROWSELECT))
>> 3788         nmlvcd.clrTextBk = CLR_NONE;
>> I guess the call to prepaint_setup should come _after_ the if
>> with FULLROWSELECT, no?
> Depends. Right now this code does nothing (and I was going to remove it
> anyway) - the only place where clrTextBk is read from is in
> prepaint_setup() - but prepaint_setup() is not called for subitems (and
> the CLR_NONE override is only done for subitems).

Well, but that's the point: now that prepaint_setup() is always called
(I agree with that change), this would do what we want if only we said
the CLR_NONE _before_ the call to prepaint_setup() where it's being
acted on.

Wouldn't that solve the problem?

Dimi Paun <dimi at lattica.com>
Lattica, Inc.

More information about the wine-devel mailing list