review: add Video Memory text input to winecfg Graphics/Direct3D tab

Laurent Vromman laurent at
Wed May 16 08:18:22 CDT 2007

 		case CBN_SELCHANGE: {
 		    SendMessage(GetParent(hDlg), PSM_CHANGED, 0, 0);
 		    switch (LOWORD(wParam)) {
-		    case IDC_D3D_VSHADER_MODE: on_d3d_vshader_mode_changed(hDlg); break;
-		    }
+                case IDC_D3D_VSHADER_MODE: on_d3d_vshader_mode_changed(hDlg); break;
+                case IDC_VIDEOMEMORY_SIZE_COMBO: set_from_videomemory_size_changed(hDlg); break;
+            }

I believe you should align your indentation method on the one the file already uses (ie tabs, not spaces).

+// vim:sw=4:expandtab

This has nothing to do with wine


On Wed, 16 May 2007 15:03:52 +0200, Vit Hrachovy <vit.hrachovy at> wrote:
> Hi,
> the attached patch adds new editable combobox input 'Video Memory size'
> for Graphics/Direct3D tab of winecfg.
> I've tried to implement Frank's comments to English language only.
> Please consider this patch as a proposal, so if it gets positive review,
> I'll propagate the changes to all remaining language resources.
> May I kindly ask someone for the patch review?
> Regards
> Vit

More information about the wine-devel mailing list