cabinet: Revert "cabinet: Fix for FDICopy with an empty cabinet file."
truiken at gmail.com
Sat Apr 26 01:09:21 CDT 2008
On Sat, Apr 26, 2008 at 1:03 AM, Reece Dunn <msclrhd at googlemail.com> wrote:
> 2008/4/26 James Hawkins <jhawkins at codeweavers.com>:
> > Hi,
> > The test was incorrect and failed on all platforms. Vitaly, please
> > ask someone to test your patches on a real windows system in the
> > future if you don't have access to one.
> Wouldn't it be better to actually fix the test case than revert it all together?
> Just simply change line 630:
> - ok(ret, "Expected FDICopy to succeed\n");
> + ok(!ret, "Expected FDICopy to fail\n");
> and remove the todo_wine. Adding a GetLastError check would be good as well.
Have you actually read the patch or the changelog for that matter?
More information about the wine-devel