Patchwatcher: failed regression tests: d3dx8: replace loops with explicit computations to make them faster [PATCH] d3dx8: replace loops by explicit computations

Zachary Goldberg zgold550 at gmail.com
Sat Aug 23 10:30:02 CDT 2008


On Sat, Aug 23, 2008 at 8:05 AM, Dan Kegel <dank at kegel.com> wrote:
> Patchwatcher notes that the conformance test fails here:

> Also: did you benchmark this change to verify it actually made
> things faster?  Unrolling loops is no longer as sure-fire a win as
> it used to be.  I'm inclined to prefer the more compact, clear
> loop unless there's hard evidence it's > 1% slower.
> - Dan
>

I'de bet good money that GCC already unrolled those loops with -O2 and
greater.  I do agree with Dan though that doing a test on a standard
intel core machine and a k8 machine to see what reality looks like is
best.



More information about the wine-devel mailing list