Any problems with these wineconsole patches?

Martin Storsjö martin at martin.st
Thu Dec 4 02:40:08 CST 2008


Hi,

In addition to the select vs poll patch to wineconsole, I sent two other 
unrelated minor patches for wineconsole last Friday (attached here); are 
there any obvious problems with these, prohibiting them from getting 
merged?

The first one simply makes fallbacks from the curses to the user backend 
work if the curses library isn't found; not only in the case when the 
curses backend isn't compiled in at all.

The second one makes --use-event not resetting the backend to user, since 
that's already the default. By setting the environment variable 
WINECONSOLE="wineconsole --backend=curses", the user could make all 
implicitly opened consoles be curses based consoles -- if --use-event 
wouldn't reset the backend back to user as it does at the moment.

Regards,
// Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-wineconsole-Fallback-to-window-based-console-if-the.patch
Type: text/x-diff
Size: 1431 bytes
Desc: 
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20081204/5e5366ef/attachment.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-wineconsole-Don-t-force-a-window-backend-when-use.patch
Type: text/x-diff
Size: 1521 bytes
Desc: 
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20081204/5e5366ef/attachment-0001.patch 


More information about the wine-devel mailing list