[5/6] ddraw: fix palette copying when destination palette is NULL
hverbeet at gmail.com
Tue Jan 1 10:38:07 CST 2008
On 01/01/2008, Stefan Dösinger <stefan at codeweavers.com> wrote:
> It is likely that Alexandre was waiting for an OK from me or Henri. He is the
> only committer, but when someone he doesn't know sends a patch he usually
> waits for the OK from someone who is maintaining the part of Wine. I think I
> forgot to send an OK mail to the test when you submitted it.
I didn't see anything obviously wrong with the test, except perhaps
checking hr against D3D_OK, but ddraw is more your area.
> * You don't have to set the render states unless you need a different setting
> than the previous tests leave behind
I don't think it's a bad thing to do though... it's pretty useful the
be able to comment out the other tests without breaking the current
test, especially when writing new tests. In general, we might want to
consider using a new device for each test to prevent states from one
test interfering with those from another test.
More information about the wine-devel