Update: comctl32: fix listview select-all

Vitaliy Margolen wine-devel at kievinfo.com
Sat Jul 5 20:13:26 CDT 2008

winehq.10.drkshadow at spamgourmet.com wrote:
> Fixes the Listview control to not individually select and focus each 
> items. Has the added bugfix that it keeps the same item focused as was 
> to begin with, and doesn't scroll the list.
> Updated: my if was incorrect and it was handling cases it shouldn't have 
> handled. It's improved now, and as far as I can tell handles only the 
> select-all case.

Please fix the formatting - 4 spaces indentation. No tabs. Do not reformat 
the lines that you did not modify. Follow the file style with curly brackets 
- here they go on the separate line.

Is there a reason you added whole new function SelectAll()  which is used in 
only one place and has only 4 lines?

And the most important - you missed your real name. Patches from anonymous 
posters are not accepted.


More information about the wine-devel mailing list