Revert "winemp3: Don't keep unused data buffered."

Maarten Lankhorst m.b.lankhorst at gmail.com
Wed Jul 9 18:18:50 CDT 2008


Hi Chris,

2008/7/9 Chris Robinson <chris.kcat at gmail.com>:
> On Wednesday 09 July 2008 11:44:17 am Maarten Lankhorst wrote:
>> This reverts commit 8f46a5119249562aceabff6d120948cbfacb6423.
>> The data isn't unused, mp3's can set up 'bit buckets', so while the
>> bit rate is constant, some data is needed anyway for later playback.
>> ---
>
> I don't believe reverting this is correct. Some apps needed this change to
> keep from stopping the stream prematurely (indeed, acmwrapper does not make
> sure all data is flushed out after using all input data). See bug 11659
Try any mp3 in windows media player 10 with and without your patch, it
makes mp3 playback there completely broken.

Cheers,
Maarten.



More information about the wine-devel mailing list