Revert "winemp3: Don't keep unused data buffered."
chris.kcat at gmail.com
Wed Jul 9 18:42:34 CDT 2008
On Wednesday 09 July 2008 04:18:50 pm Maarten Lankhorst wrote:
> Try any mp3 in windows media player 10 with and without your patch, it
> makes mp3 playback there completely broken.
As mentioned in the bug <http://bugs.winehq.org/show_bug.cgi?id=11805>
The problem is either the lack of error propogating from winemp3.acm (all
errors by it are swallowed up and acmStreamConvert returns no error), or very
small data sources (such that not enough is provided to decode at least one
full frame) do need to be buffered. Some testing needs to be done, although
<http://bugs.winehq.org/show_bug.cgi?id=11659> clearly shows that "extra"
data is not held when given enough to produce some output.
More information about the wine-devel