Missed patches concerning valgrind-detected issues

Alexandre Julliard julliard at winehq.org
Tue Jul 29 06:19:32 CDT 2008

"Kirill K. Smirnov" <lich at math.spbu.ru> writes:

> Hello, Alexandre,
> Is there anything wrong with this couple of patches:
> dsound: check error status of waveOutGetVolume() function before using 
> retrieved values (found by valgrind)
> http://www.winehq.org/pipermail/wine-patches/2008-July/058124.html

You should most likely propagate the errors instead of assuming default

> cmd: Do not deceive CompareString() passing more characters then we really 
> have (found by valgrind)
> http://www.winehq.org/pipermail/wine-patches/2008-July/058504.html

There shouldn't be any need to pass an explicit length here, the code is

Alexandre Julliard
julliard at winehq.org

More information about the wine-devel mailing list