(resend) msi: Fix bug in handling of multivolume CAB files.

James Hawkins truiken at gmail.com
Tue Mar 4 14:03:09 CST 2008

On Tue, Mar 4, 2008 at 11:51 AM, Ove Kaaven <ovek at transgaming.com> wrote:
> The email address in the patch was wrong, sending it again.
> >From b88a43dbc2234c8b35ee4fa7bb4f275475b8d821 Mon Sep 17 00:00:00 2001
>  From: Ove Kaaven <ovek at transgaming.com>
>  Date: Tue, 4 Mar 2008 18:16:27 +0100
>  Subject: [PATCH] Fix bug in handling of multivolume CAB files.
>   After extracting a single file from a multivolume CAB file, sometimes
>   information about the next CAB file to extract from would not be loaded,
>   because the is_continuous state was previously only properly reset if a
>   file happened to be partially extracted from the last volume of a
>   multivolume series.

A lot of time has been spent fixing cab/media related bugs in
installers, as the behavior is very fickle (and easily breakable), so
can you please add a test case first?  See the multicab tests that are
already in install.c.  They will fail in wine because our cabinet.dll
cannot create compressed cabinets, but assuming you test in Windows or
use native cabinet.dll, it'll still verify that the patch is correct.

James Hawkins

More information about the wine-devel mailing list