[PATCH 1/3] msxml3: Return xmlnode object from create_basic_node.

Jacek Caban jacek at codeweavers.com
Thu Aug 20 10:39:26 CDT 2009

Alexandre Julliard wrote:
> Jacek Caban <jacek at codeweavers.com> writes:
>> I just feel that it's better to have a wrapper to avoid explicit casts
>> in the code and have vtbl logic separated from other code. I usually
>> use macros, but I know you don't like it, so I used an inline function
>> here.
> For secondary vtbls that's definitely a good idea (as long as you are
> using inline functions and not macros...)  The main vtbl is a bit
> different because by design its address and the object are the same
> thing, so you can use a cast and ignore the fact that there even is a
> vtbl involved.

That's one of things in the design that I'd like to change. This 
assumption doesn't work well for object inheritance.
> Though I'm not opposed to a function wrapper either, just
> with a more explicit name.

I will use IXMLDOMNode_from_impl then.


More information about the wine-devel mailing list