[3/4] d3dx9: Implement D3DXAssembleShader function, really basic shader assembler.

Henri Verbeet hverbeet at gmail.com
Tue Dec 29 10:03:54 CST 2009


2009/12/29 Matteo Bruni <matteo.mystral at gmail.com>:
> I added the fake parser for two reasons: because I have to initialize
> an asm_parser structure anyway in the create_xxxx_parser functions
> (and I prefer to use parser_fake for the unimplemented shader versions
> instead of parser_vs_3) and I want to avoid having some tests for the
> other shader versions pass "by chance" inside the todo_wine (this is
> accomplished by the asmparser_end_fake function... probably this can
> be seen as a hack).
> Agreed on the structure fields.
>
Can't you just let the parser fail when it encounters an unsupported
shader version? That's more or less what happens anyway, but I don't
think you have to wait until after parsing all the instructions for
that.



More information about the wine-devel mailing list