Updated DIB Engine

[Erich Hoover]

On Sun, Jan 25, 2009 at 11:25 AM, Massimo Del Fedele <max at veneto.com> wrote:

> Erich Hoover ha scritto:
> >
> > I haven't looked into your implementation in much detail (I need more
> > hours in a day, I swear), but would it be possible to pass all the stubs
> > on so that unimplemented functionality still works even if it's dog
> > slow?  It'd be nice if we could take advantage of the implemented
> > features, still be able to handle everything, and then spew a "FIXME:
> > Help Wine run faster by implementing this function in the DIB engine!"
> > for features that are not handled yet.  (yeah, yeah, I want my cake and
> > be able to eat it too)
> >
> > Erich Hoover
> > ehoover at mines.edu <mailto:ehoover at mines.edu>
> >
>
> Well, by now many functions are stubbed (with disabled FIXMEs for
> speed), and 3 apps I've tested on it works ok.
> Some bad graphics, but mostly usable.
> You can test it easily and, if you like, you can enable all the stubs
> FIXMEs uncommenting a #define on header file.
>
> Ciao
>
> Max
>
>
What I was trying to say is if you could have something like this for all
the stubs:
----
BOOL DIBDRV_AlphaBlend( DIBDRVPHYSDEV *devDst, INT xDst, INT yDst, INT
widthDst, INT heightDst,
                        DIBDRVPHYSDEV *devSrc, INT xSrc, INT ySrc, INT
widthSrc, INT heightSrc,
                        BLENDFUNCTION blendfn)
{
    FIXME("reverting to slow behavior!\n");
    return TheOldBehavior->AlphaBlend(...);
}
----

While I'm obviously not greatly familiar with this code, it seems like the
engine would have a better chance of being successful if unimplemented
features fell back to the old behavior.  It seems like that would allow you
to gradually transition over to the integrated DIB engine a little bit at a
time, rather than having a lot of unavailable features that would all need
to be implemented before the integrated DIB engine could be turned on for
everyone.  Even if you had to create a special surface and copy the bitmap
back and forth every time you had to revert to the old behavior it seems
like it would at least provide a good testbed.

Erich Hoover
ehoover at mines.edu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.winehq.org/pipermail/wine-devel/attachments/20090125/2c8e297a/attachment.htm