Use GCC's -Wlogical-op if possible

Paul Vriens paul.vriens.wine at gmail.com
Fri Jun 19 02:43:43 CDT 2009


Gerald Pfeifer wrote:
> On Thu, 18 Jun 2009, Austin English wrote:
>> Causes 106 more warnings on 4.3.3 of this sort:
>> tab.c:693: warning: logical ?&&? with non-zero constant will always
>> evaluate as true
>> cert.c:1627: warning: logical ?||? with non-zero constant will always
>> evaluate as true
> 
> This is strange.  In that case, let's hold off and I will work on 
> addressing these first (testing with even more versions of GCC than
> I had done).
> 
> Gerald
> 
> 
> 
I have about 70 warnings with 4.3.2.

I already sent two patches and found a few more bugs. If you want I can 
start sending in patches for those as well (don't want to duplicate work 
of course).

-- 
Cheers,

Paul.



More information about the wine-devel mailing list